OperatorMulticast.connect(connection) should not return null #2779
+45
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n on multiple calls, address possible race condition provoking IAE
| final Observable<? extends T> source; | ||
| final Object guard; | ||
| final Func0<? extends Subject<? super T, ? extends R>> subjectFactory; | ||
| private final Observable<? extends T> source; |
There was a problem hiding this comment.
I try to avoid private because the compiler generates accessor methods which slows down the interpreter phase and makes an extra hop while debugging methods.
|
Thanks @akarnokd, sharp-eyed as ever. I used a final AtomicReference to help with the == this check, is this the idiom you'd use in this situation? |
|
Thanks! |
akarnokd
added a commit
that referenced
this pull request
Mar 2, 2015
OperatorMulticast.connect(connection) should not return null
This was referenced Mar 5, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #2774
Changes include
OperatorMulticast(will doOperatorPublishin another PR once have sorted this one out)OnSubscribeMulticastTesttoOperatorMulticastTestObservable.subscribe(sub)is called with sub=null (unsubscription occurs between L144 and L145 on old code).